Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r170682155
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
 ---
    @@ -115,6 +116,19 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments) extends
         }
       }
     
    +  if (isClusterMode) {
    +    val nmHostPort = WebAppUtils.getWebAppBindURL(yarnConf, 
YarnConfiguration.NM_BIND_HOST,
    --- End diff --
    
    Can this be done above where the configuration is prepared? Then you 
wouldn't need to manually add this to the system properties since it would be 
done by the existing code.
    
    Also it would be good to add a comment explaining why this is needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to