Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20618#discussion_r171167374
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -512,7 +529,11 @@ case class Rint(child: Expression) extends
UnaryMathExpression(math.rint, "ROUND
case class Signum(child: Expression) extends
UnaryMathExpression(math.signum, "SIGNUM")
@ExpressionDescription(
- usage = "_FUNC_(expr) - Returns the sine of `expr`.",
+ usage = "_FUNC_(expr) - Returns the sine of `expr`, as if computed by
`java.lang.Math._FUNC_`.",
--- End diff --
I don't know the history of why the text is different here vs python/R
https://github.com/apache/spark/blob/master/R/pkg/R/functions.R#L1466
I don't think the doc grouping in R is relevant - the text is there.
Generally we try to match the text in scala but I don't feel strongly either
way in this case.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
