Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20670#discussion_r171182870
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala
---
@@ -192,4 +192,17 @@ class InferFiltersFromConstraintsSuite extends
PlanTest {
comparePlans(Optimize.execute(original.analyze), correct.analyze)
}
+
+ test("SPARK-23405:single left-semi join, filter out nulls on either side
on equi-join keys") {
+ val x = testRelation.subquery('x)
+ val y = testRelation.subquery('y)
+ val originalQuery = x.join(y, LeftSemi,
+ condition = Some("x.a".attr === "y.a".attr)).analyze
--- End diff --
nit: we can create a `val condition = Some("x.a".attr === "y.a".attr)` to
reduce duplicated code
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
