Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20692#discussion_r171334033
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2264,4 +2264,18 @@ class DataFrameSuite extends QueryTest with
SharedSQLContext {
checkAnswer(df, Row(0, 10) :: Nil)
assert(df.queryExecution.executedPlan.isInstanceOf[WholeStageCodegenExec])
}
+
+ test("SPARK-23531: explain should show attributes' type") {
--- End diff --
Hi, @mgaido91 .
For the test case, could you
- Add a test coverage for `explain(true)`, too?
- Try to add `explain.sql` into `SQLQueryTestSuite`?
cc @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
