Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r171588018
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -1380,10 +1428,9 @@ public void write(Kryo kryo, Output out) {
     
       @Override
       public void read(Kryo kryo, Input in) {
    -    this.offset = BYTE_ARRAY_OFFSET;
    -    this.numBytes = in.readInt();
    -    this.base = new byte[numBytes];
    -    in.read((byte[]) base);
    +    int numBytes = in.readInt();
    +    base = ByteArrayMemoryBlock.fromArray(new byte[numBytes]);
    +    in.read(((ByteArrayMemoryBlock)base).getByteArray());
    --- End diff --
    
    nit:
    ```
    int numBytes = in.readInt()
    val bytes = new byte[numBytes]
    in.read((byts)
    base = ByteArrayMemoryBlock.fromArray(bytes)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to