Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20600#discussion_r171637778
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala
---
@@ -155,34 +183,55 @@ object BisectingKMeansModel extends
Loader[BisectingKMeansModel] {
spark.createDataFrame(data).write.parquet(Loader.dataPath(path))
}
- private def getNodes(node: ClusteringTreeNode):
Array[ClusteringTreeNode] = {
- if (node.children.isEmpty) {
- Array(node)
- } else {
- node.children.flatMap(getNodes(_)) ++ Array(node)
- }
- }
-
- def load(sc: SparkContext, path: String, rootId: Int):
BisectingKMeansModel = {
+ def load(sc: SparkContext, path: String): BisectingKMeansModel = {
--- End diff --
Oh right, that's OK then. It's a false positive as it's public in the byte
code but not really public.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
