GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/2930

    [SPARK-4076] Parameter expansion in spark-config is wrong

    In sbin/spark-config.sh, parameter expansion is used to extract source root 
as follows.
    
        this="${BASH_SOURCE-$0}"
    
    I think, the parameter expansion should be ":" instead of "".
    If we use "-" and BASH_SOURCE="", (empty character is set, not unset),
    "" (empty character) is set to $this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark SPARK-4076

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2930
    
----
commit 32a03707b65a00a8c4ef57e7dc7ad0566b7a472c
Author: Kousuke Saruta <saru...@oss.nttdata.co.jp>
Date:   2014-10-24T14:26:28Z

    Fixed wrong parameter expansion

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to