Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20686#discussion_r171938542
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
    @@ -32,10 +31,20 @@ class RFormulaSuite extends MLTest with 
DefaultReadWriteTest {
       def testRFormulaTransform[A: Encoder](
           dataframe: DataFrame,
           formulaModel: RFormulaModel,
    -      expected: DataFrame): Unit = {
    +      expected: DataFrame,
    +      expectedAttributes: AttributeGroup*): Unit = {
    +    val resultSchema = formulaModel.transformSchema(dataframe.schema)
    +    assert(resultSchema.json == expected.schema.json)
    --- End diff --
    
    I know they are different but 'schema.json' based compare is more 
restrictive: it contains the metadata as well. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to