Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20722#discussion_r171968410
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
 ---
    @@ -159,6 +159,19 @@ private[spark] class Client(
             logInfo(s"Waiting for application $appName to finish...")
             watcher.awaitCompletion()
             logInfo(s"Application $appName finished.")
    +        try {
    --- End diff --
    
    Why are we doing this in client code? Driver shutdown is the right place to 
perform cleanup right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to