Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20710#discussion_r171993983
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/streaming/StreamWriter.java
 ---
    @@ -39,21 +36,21 @@
        * If this method fails (by throwing an exception), this writing job is 
considered to have been
        * failed, and the execution engine will attempt to call {@link 
#abort(WriterCommitMessage[])}.
        *
    -   * To support exactly-once processing, writer implementations should 
ensure that this method is
    -   * idempotent. The execution engine may call commit() multiple times for 
the same epoch
    -   * in some circumstances.
    +   * The execution engine may call commit() multiple times for the same 
epoch in some circumstances.
    --- End diff --
    
    Somewhere in this file, add docs about what epochId means for MB and C 
execution. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to