GitHub user yogeshg opened a pull request:

    https://github.com/apache/spark/pull/20724

    [SPARK-18630][PYTHON][ML] Move del method from JavaParams to JavaWrapper; 
add tests

    ## What changes were proposed in this pull request?
    
    Move del method from JavaParams to JavaWrapper; add tests
    
    ## How was this patch tested?
    
    I ran pyspark tests  agains `pyspark-ml` module
    `./python/run-tests --python-executables=$(which python) 
--modules=pyspark-ml`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yogeshg/spark java_wrapper_memory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20724
    
----
commit 50acecc3d12778f1f30ca636b6e83163f1fc775a
Author: Yogesh Garg <yogesh(dot)garg()databricks(dot)com>
Date:   2018-03-03T00:00:40Z

    add test case for JavaWrapper that displays memory leak for JavaWrapper but 
not JavaParams

commit d36c1a10cd318d9ddeb2717737248c974a2349f1
Author: Yogesh Garg <yogesh(dot)garg()databricks(dot)com>
Date:   2018-03-03T00:01:19Z

    send the delete method from JavaParams to JavaWrapper

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to