Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20705#discussion_r172022980
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2150,7 +2150,8 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
test("data source table created in InMemoryCatalog should be able to
read/write") {
withTable("tbl") {
- sql("CREATE TABLE tbl(i INT, j STRING) USING parquet")
+ val provider = spark.sessionState.conf.defaultDataSourceName
--- End diff --
Hm .. how about just explicitly setting `spark.sql.sources.default` to
`parquet` in all places rather than using the default? If it's set to, for
example, `text`, this test becomes failed. I thought it's a bit odd a test it
is dependent on a default value.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
