Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20657#discussion_r172321966
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1009,7 +987,7 @@ private[spark] class Client(
}
def setupCredentials(): Unit = {
- loginFromKeytab = sparkConf.contains(PRINCIPAL.key)
+ loginFromKeytab = sparkConf.contains(PRINCIPAL)
--- End diff --
if a user only specifies keytab, but no principal, I don't think this will
fail in a friendly way. This will be a no-op, so it'll succeed, and then in
ApplicationMaster / AMCredentialRenewer, you'll get an error trying to do
`sparkConf.get(PRINCIPAL).get`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
