GitHub user henryr opened a pull request:

    https://github.com/apache/spark/pull/20740

    [SPARK-23604][SQL] Change Statistics.isEmpty to !Statistics.hasNonNul…

    …lValue
    
    ## What changes were proposed in this pull request?
    
    Parquet 1.9 will change the semantics of Statistics.isEmpty slightly
    to reflect if the null value count has been set. That breaks a
    timestamp interoperability test that cares only about whether there
    are column values present in the statistics of a written file for an
    INT96 column. Fix by using Statistics.hasNonNullValue instead.
    
    ## How was this patch tested?
    
    Unit tests continue to pass against Parquet 1.8, and also pass against
    a Parquet build including PARQUET-1217.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/henryr/spark spark-23604

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20740
    
----
commit b86c0bee16f85ad1f7d4e3351647ee5d0582d005
Author: Henry Robinson <henry@...>
Date:   2018-03-05T20:59:53Z

    [SPARK-23604][SQL] Change Statistics.isEmpty to !Statistics.hasNonNullValue
    
    ## What changes were proposed in this pull request?
    
    Parquet 1.9 will change the semantics of Statistics.isEmpty slightly
    to reflect if the null value count has been set. That breaks a
    timestamp interoperability test that cares only about whether there
    are column values present in the statistics of a written file for an
    INT96 column. Fix by using Statistics.hasNonNullValue instead.
    
    ## How was this patch tested?
    
    Unit tests continue to pass against Parquet 1.8, and also pass against
    a Parquet build including PARQUET-1217.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to