Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20741#discussion_r172333065
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
 ---
    @@ -75,4 +75,14 @@ class ObjectExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
           checkEvaluation(unwrapObject, expected, 
InternalRow.fromSeq(Seq(input)))
         }
       }
    +
    +  test("SPARK-23586: WrapOption should support interpreted execution") {
    +    val cls = ObjectType(classOf[java.lang.Integer])
    +    val inputObject = BoundReference(0, cls, nullable = true)
    +    val unwrapObject = WrapOption(inputObject, cls)
    --- End diff --
    
    NIT: `unwrapObject`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to