Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20727#discussion_r172336258
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala
---
@@ -30,9 +30,19 @@ import
org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl
/**
* An adaptor from a [[PartitionedFile]] to an [[Iterator]] of [[Text]],
which are all of the lines
* in that file.
+ *
+ * @param file A part (i.e. "block") of a single file that should be read
line by line.
+ * @param lineSeparator A line separator that should be used for each
line. If the value is `\n`,
+ * it covers `\r`, `\r\n` and `\n`.
+ * @param conf Hadoop configuration
*/
class HadoopFileLinesReader(
- file: PartitionedFile, conf: Configuration) extends Iterator[Text]
with Closeable {
+ file: PartitionedFile,
+ lineSeparator: String,
+ conf: Configuration) extends Iterator[Text] with Closeable {
--- End diff --
I cannot predict where the class could be used but I believe we should keep
backward compatibility by sources. I mean it would be better to add new
parameter after `conf: Configuration` with default value which preserve old
behavior.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
