Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r172364040
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -50,12 +52,12 @@
// These are only updated by readExternal() or read()
@Nonnull
- private Object base;
- private long offset;
+ private MemoryBlock base;
+ // While numBytes has the same value as base, length, to keep as int
avoids cast from long to int
private int numBytes;
- public Object getBaseObject() { return base; }
- public long getBaseOffset() { return offset; }
+ public MemoryBlock getMemoryBlock() { return base; }
+ private long getBaseOffset() { return base.getBaseOffset(); }
--- End diff --
can we keep it public? `UTF8String` is kind of a public class.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
