Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20726#discussion_r172403479
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsReportPartitioning.java
---
@@ -23,6 +23,10 @@
/**
* A mix in interface for {@link DataSourceReader}. Data source readers
can implement this
* interface to report data partitioning and try to avoid shuffle at Spark
side.
+ *
+ * Note that Spark will always infer a
+ * {@link org.apache.spark.sql.catalyst.plans.physical.SinglePartition}
partitioning when the
+ * reader creates exactly 1 {@link DataReaderFactory}.
--- End diff --
nit: .... no matter the reader implements this interface or not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
