Github user hvanhovell commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,345 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.sql.catalyst
    +import org.apache.spark.SparkException
    +import org.apache.spark.sql.catalyst.expressions.{Expression, 
GenericInternalRow, Nondeterministic, SpecializedGetters, UnsafeArrayData, 
UnsafeMapData, UnsafeProjection, UnsafeProjectionCreator, UnsafeRow}
    +import org.apache.spark.sql.catalyst.expressions.codegen.{BufferHolder, 
UnsafeArrayWriter, UnsafeRowWriter, UnsafeWriter}
    +import org.apache.spark.sql.catalyst.util.ArrayData
    +import org.apache.spark.sql.types.{UserDefinedType, _}
    +import org.apache.spark.unsafe.Platform
    + * An interpreted unsafe projection. This class reuses the [[UnsafeRow]] 
it produces, a consumer
    + * should copy the row if it is being buffered. This class is not thread 
    + *
    + * @param expressions that produces the resulting fields. These 
expressions must be bound
    + *                    to a schema.
    + */
    +class InterpretedUnsafeProjection(expressions: Array[Expression]) extends 
UnsafeProjection {
    --- End diff --
    The current implementation takes a two step approach, first it evaluates 
the expressions and puts them in an intermediate row and it then converts this 
row to an `UnsafeRow`. We could also just create a converter from `InternalRow` 
to `UnsafeRow` and punt the projection work of to a 


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to