Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20753#discussion_r173361869
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala
 ---
    @@ -95,6 +162,21 @@ class ObjectExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         checkEvaluation(createExternalRow, Row.fromSeq(Seq(1, "x")), 
InternalRow.fromSeq(Seq()))
       }
     
    +  // This is an alternative version of `checkEvaluation` to compare results
    --- End diff --
    
    If this pr is merged first, I'll remove this in my pr.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to