Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20780#discussion_r173366467
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala 
---
    @@ -335,7 +335,7 @@ abstract class HadoopFsRelationTest extends QueryTest 
with SQLTestUtils with Tes
     
       test("saveAsTable()/load() - non-partitioned table - ErrorIfExists") {
         withTable("t") {
    -      sql("CREATE TABLE t(i INT) USING parquet")
    +      sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
           intercept[AnalysisException] {
             
testDF.write.format(dataSourceName).mode(SaveMode.ErrorIfExists).saveAsTable("t")
           }
    --- End diff --
    
    Could you add an error message check logic here explicitly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to