Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173545177
--- Diff: python/pyspark/ml/tests.py ---
@@ -1980,8 +1997,8 @@ def test_java_params(self):
pyspark.ml.regression]
for module in modules:
for name, cls in inspect.getmembers(module, inspect.isclass):
- if not name.endswith('Model') and issubclass(cls,
JavaParams)\
- and not inspect.isabstract(cls):
+ if not name.endswith('Model') and not
name.endswith('Params')\
--- End diff --
Just to make sure I've understood whats happening here, were avoiding doing
the default params test on non-concrete classes like the base params shared
between the model and the estimator and instead testing just the model and
estimator on their own right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
