Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20757#discussion_r173616654
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -1440,7 +1463,7 @@ case class ValidateExternalType(child: Expression, 
expected: DataType)
             Seq(classOf[java.math.BigDecimal], classOf[scala.math.BigDecimal], 
classOf[Decimal])
               .map(cls => s"$obj instanceof ${cls.getName}").mkString(" || ")
           case _: ArrayType =>
    -        s"$obj instanceof ${classOf[Seq[_]].getName} || 
$obj.getClass().isArray()"
    +        s"$obj.getClass().isArray() || $obj instanceof 
${classOf[Seq[_]].getName}"
    --- End diff --
    
    Why we need to change codegen implementation?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to