Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20787#discussion_r173619271
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -2708,7 +2708,8 @@ object functions {
       def minute(e: Column): Column = withExpr { Minute(e.expr) }
     
       /**
    -   * Returns number of months between dates `date1` and `date2`.
    +   * Returns number of months between dates `date1` and `date2`. If 
`date1` is later than `date2`,
    +   * then the result is positive.
    --- End diff --
    
    Can we resemble this:
    
    
https://github.com/apache/spark/blob/6e36d8d56279a2c5c92c8df8e89ee99b514817e7/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L884-L888
    
    ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to