Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2937#discussion_r19369677
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/SortDataFormat.scala ---
@@ -34,9 +34,20 @@ import scala.reflect.ClassTag
*/
// TODO: Making Buffer a real trait would be a better abstraction, but
adds some complexity.
private[spark] trait SortDataFormat[K, Buffer] extends Any {
+
+ /** Creates a new mutable key for reuse. */
+ protected def newKey(): K = null.asInstanceOf[K]
+
/** Return the sort key for the element at the given index. */
protected def getKey(data: Buffer, pos: Int): K
+ /**
+ * Returns the sort key for the element at the given index and reuse the
input key if possible.
+ */
+ protected def getKey(data: Buffer, pos: Int, reuse: K): K = {
--- End diff --
It's somewhat surprising that a universal trait can have a default
implementation, but maybe we can convert this to an abstract class to ensure
it's still compiled into simple Java bytecode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
