Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20774#discussion_r173715303
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -135,11 +135,14 @@ object TypeCoercion {
         case (DateType, StringType) => Some(StringType)
         case (StringType, TimestampType) => Some(StringType)
         case (TimestampType, StringType) => Some(StringType)
    -    case (TimestampType, DateType) => Some(StringType)
    -    case (DateType, TimestampType) => Some(StringType)
         case (StringType, NullType) => Some(StringType)
         case (NullType, StringType) => Some(StringType)
     
    +    // Cast to TimestampType when we compare DateType with TimestampType
    +    // i.e. TimeStamp('2017-03-01 00:00:00') eq Date('2017-03-01') = true
    --- End diff --
    
    Thanks 
    @dongjoon-hyun are you pointing out [this HIVE JIRA 
entry|https://issues.apache.org/jira/browse/HIVE-15236] in [this 
comment](https://issues.apache.org/jira/browse/SPARK-23549?focusedCommentId=16391877&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16391877)?
 Or other HIVE JIRA entries?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to