Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20802#discussion_r174032948
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -975,6 +975,8 @@ private[spark] object Utils extends Logging {
     
       def checkHost(host: String) {
         assert(host != null && host.indexOf(':') == -1, s"Expected hostname 
(not IP) but got $host")
    +    assert(host.matches("^[a-zA-Z0-9-.]+$"),
    --- End diff --
    
    Further more, the regex even doesn't guarantee a valid host, so it looks 
not very reasonable to have a check like that from any point of view.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to