Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r174046867 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/BufferedRowIterator.java --- @@ -65,7 +65,7 @@ public long durationMs() { /** * Append a row to currentRows. */ - protected void append(InternalRow row) { + public void append(InternalRow row) { --- End diff -- nit: Although we added the test, should we also add a short sentence that said this is public so inner classes can also access it?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org