Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20816#discussion_r174301967
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala
 ---
    @@ -204,4 +205,40 @@ class InferFiltersFromConstraintsSuite extends 
PlanTest {
         val optimized = Optimize.execute(originalQuery)
         comparePlans(optimized, correctAnswer)
       }
    +
    +  test("SPARK-21479: Outer join after-join filters push down to 
null-supplying side") {
    +    val x = testRelation.subquery('x)
    +    val y = testRelation.subquery('y)
    +    val condition = Some("x.a".attr === "y.a".attr)
    +    val originalQuery = x.join(y, LeftOuter, condition).where("x.a".attr 
=== 2).analyze
    +    val left = x.where(IsNotNull('a) && 'a === 2)
    +    val right = y.where(IsNotNull('a) && 'a === 2)
    +    val correctAnswer = left.join(right, LeftOuter, condition).analyze
    +    val optimized = Optimize.execute(originalQuery)
    +    comparePlans(optimized, correctAnswer)
    +  }
    +
    +  test("SPARK-21479: Outer join pre-existing filters push down to 
null-supplying side") {
    +    val x = testRelation.subquery('x)
    +    val y = testRelation.subquery('y)
    +    val condition = Some("x.a".attr === "y.a".attr)
    +    val originalQuery = x.join(y.where("y.a".attr > 5), RightOuter, 
condition).analyze
    +    val left = x.where(IsNotNull('a) && 'a > 5)
    +    val right = y.where(IsNotNull('a) && 'a > 5)
    +    val correctAnswer = left.join(right, RightOuter, condition).analyze
    +    val optimized = Optimize.execute(originalQuery)
    +    comparePlans(optimized, correctAnswer)
    +  }
    +
    +  test("SPARK-21479: Outer join no filter push down to preserved side") {
    +    val x = testRelation.subquery('x)
    +    val y = testRelation.subquery('y)
    +    val condition = Some("x.a".attr === "y.a".attr)
    +    val originalQuery = x.join(y.where("y.a".attr === 1), LeftOuter, 
condition).analyze
    +    val left = x
    +    val right = y.where(IsNotNull('a) && 'a === 1)
    +    val correctAnswer = left.join(right, LeftOuter, condition).analyze
    +    val optimized = Optimize.execute(originalQuery)
    +    comparePlans(optimized, correctAnswer)
    +  }
    --- End diff --
    
    Yeah. Could you change the `InferFiltersFromConstraints` directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to