Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r174333828 --- Diff: common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java --- @@ -38,12 +39,18 @@ public static int hashLong(long input) { return (int) ((input >>> 32) ^ input); } - public static int hashUnsafeBytes(Object base, long offset, int lengthInBytes) { + public static int hashUnsafeBytesBlock(MemoryBlock mb) { + long offset = mb.getBaseOffset(); + int lengthInBytes = (int)mb.size(); --- End diff -- Let us use `long`.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org