Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/20686#discussion_r174535931
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -299,18 +310,17 @@ class StringIndexerSuite
.setInputCol("label")
.setOutputCol("labelIndex")
- val expected = Seq(Set((0, 0.0), (1, 0.0), (2, 2.0), (3, 1.0), (4,
1.0), (5, 0.0)),
- Set((0, 2.0), (1, 2.0), (2, 0.0), (3, 1.0), (4, 1.0), (5, 2.0)),
- Set((0, 1.0), (1, 1.0), (2, 0.0), (3, 2.0), (4, 2.0), (5, 1.0)),
- Set((0, 1.0), (1, 1.0), (2, 2.0), (3, 0.0), (4, 0.0), (5, 1.0)))
+ val expected = Seq(Seq((0, 0.0), (1, 0.0), (2, 2.0), (3, 1.0), (4,
1.0), (5, 0.0)),
--- End diff --
I agree that's correct. The problem is that people tend to see these
patterns and copy them without thinking. It's best to follow patterns which
help other contributors to avoid making mistakes.
I'm OK with leaving it since this issue is scattered throughout MLlib tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
