Github user DylanGuedes commented on a diff in the pull request:
https://github.com/apache/spark/pull/20788#discussion_r174580902
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -437,10 +437,11 @@ def hint(self, name, *parameters):
if not isinstance(name, str):
raise TypeError("name should be provided as str, got
{0}".format(type(name)))
+ allowed_types = (basestring, list, float, int)
--- End diff --
At the start of the file, basestring, unicode and str becomes the same
thing, so I don't think that the Python version can cause trouble at all.
Should I make tests for both types then? Any suggestion of how to test it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
