Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20669#discussion_r174596786
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -89,26 +56,16 @@ private[spark] object KubernetesUtils {
def getOnlyRemoteFiles(uris: Iterable[String]): Iterable[String] = {
uris.filter { uri =>
val scheme = Utils.resolveURI(uri).getScheme
- scheme != "file" && scheme != "local"
+ scheme != "local"
}
}
- private def resolveFileUri(
- uri: String,
- fileDownloadPath: String,
- assumesDownloaded: Boolean): String = {
+ private def resolveFileUri(uri: String): String = {
val fileUri = Utils.resolveURI(uri)
- val fileScheme = Option(fileUri.getScheme).getOrElse("file")
+ val fileScheme = Option(fileUri.getScheme).getOrElse("non-local")
--- End diff --
Should just stick with `file` I think.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
