Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20841#discussion_r175163502
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -2504,6 +2504,10 @@ def test_conf(self):
             spark.conf.unset("bogo")
             self.assertEqual(spark.conf.get("bogo", "colombia"), "colombia")
     
    +        self.assertRaisesRegexp(Exception, "hyukjin", lambda: 
spark.conf.get("hyukjin"))
    +        self.assertEqual(spark.conf.get("hyukjin", None), None)
    +        
self.assertEqual(spark.conf.get("spark.sql.sources.partitionOverwriteMode", 
None), None)
    --- End diff --
    
    Can you add one more test to get 
`"spark.sql.sources.partitionOverwriteMode"` without `None` to see the 
difference between with and without `None`? Hopefully with a simple comment.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to