Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/16770#discussion_r175232475 --- Diff: python/pyspark/ml/tests.py --- @@ -1980,8 +1997,8 @@ def test_java_params(self): pyspark.ml.regression] for module in modules: for name, cls in inspect.getmembers(module, inspect.isclass): - if not name.endswith('Model') and issubclass(cls, JavaParams)\ - and not inspect.isabstract(cls): + if not name.endswith('Model') and not name.endswith('Params')\ --- End diff -- I'm helping get `maxDF` in python now, so after that's done I'll make a followup to add this
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org