Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20701#discussion_r175236013
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala ---
@@ -36,8 +36,9 @@ import org.apache.spark.sql.{Row, SparkSession}
* A clustering model for K-means. Each point belongs to the cluster with
the closest center.
*/
@Since("0.8.0")
-class KMeansModel @Since("2.4.0") (@Since("1.0.0") val clusterCenters:
Array[Vector],
- @Since("2.4.0") val distanceMeasure: String)
+class KMeansModel private[spark] (@Since("1.0.0") val clusterCenters:
Array[Vector],
--- End diff --
So previously the main constructor was not private, any particular reason
we are making in private? if someone else is implementing something which
extends the kmeans model this might be a little frustrating.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
