Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20327#discussion_r175629947
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
def bind(): Unit = {
assert(serverInfo.isEmpty, s"Attempted to bind $className more than
once!")
try {
- val host = Option(conf.getenv("SPARK_LOCAL_IP")).getOrElse("0.0.0.0")
+ val host = if (Utils.isClusterMode(conf)) {
--- End diff --
There's a big different between the RPC endpoint and the web UI.
For the RPC endpoint, your change is fixing a potential issue. For the web
UI, this change is potentially introducing a new issue in non-YARN mode. So
please, revert this one change and all the rest is good to go.
Otherwise I can't merge this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
