Github user andrusha commented on a diff in the pull request:
https://github.com/apache/spark/pull/20811#discussion_r175710242
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -108,6 +109,8 @@ private[spark] class ExecutorPodFactory(
nodeToLocalTaskCount: Map[String, Int]): Pod = {
val name = s"$executorPodNamePrefix-exec-$executorId"
+ val imagePullSecrets = imagePullSecret.map(new
LocalObjectReference(_)).toList
--- End diff --
@liyinan926 I made the change, but imo it looks a bit awkward, as what is
done here is just type conversion `Option[String] ~>
List[LocalObjectReference]` to make config option palatable for the k8s.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
