Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2911#issuecomment-60501805 Since merging this PR, I've started noticing some OOM failures in a test that uses SnappyOutputStream: ``` - partial aggregation without spill *** RUN ABORTED *** java.lang.OutOfMemoryError: Java heap space at org.xerial.snappy.buffer.CachedBufferAllocator.allocate(CachedBufferAllocator.java:48) at org.xerial.snappy.SnappyOutputStream.<init>(SnappyOutputStream.java:96) at org.xerial.snappy.SnappyOutputStream.<init>(SnappyOutputStream.java:83) at org.apache.spark.io.SnappyCompressionCodec.compressedOutputStream(CompressionCodec.scala:125) at org.apache.spark.storage.BlockManager.wrapForCompression(BlockManager.scala:1084) at org.apache.spark.storage.BlockManager$$anonfun$7.apply(BlockManager.scala:579) at org.apache.spark.storage.BlockManager$$anonfun$7.apply(BlockManager.scala:579) at org.apache.spark.storage.DiskBlockObjectWriter.open(BlockObjectWriter.scala:126) at org.apache.spark.storage.DiskBlockObjectWriter.write(BlockObjectWriter.scala:192) at org.apache.spark.util.collection.ExternalSorter.spillToMergeableFile(ExternalSorter.scala:300) ``` @xerial do you think there could be a memory leak in the new CachedBufferAllocator? https://github.com/xerial/snappy-java/compare/1.1.1.3...develop
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org