Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20866#discussion_r176309717
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HiveDelegationTokenProvider.scala
---
@@ -92,8 +93,8 @@ private[security] class HiveDelegationTokenProvider
s"$principal at $metastoreUri")
doAsRealUser {
- val hive = Hive.get(conf, classOf[HiveConf])
--- End diff --
Could you be more specific about the scope of this PR in the title and
description?
Although the title is `Avoid Hive.get() to compatible with different Hive
metastore`,
1. This file still has `Hive.get` at [line
246](https://github.com/apache/spark/pull/20866/files#diff-6fd847124f8eae45ba2de1cf7d6296feL246).
2. `getDelegationTokenFromMetaStore` of `CLIService.java` also has
[Hive.get](https://github.com/apache/hive/blob/rel/release-2.3.2/service/src/java/org/apache/hive/service/cli/CLIService.java#L575).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]