GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/20878

    [MINOR][PYTHON] Remove unused codes in schema parsing logics of PySpark

    ## What changes were proposed in this pull request?
    
    This PR proposes to remove out unused codes, `_ignore_brackets_split` and 
`_BRACKETS`.
    
    `_ignore_brackets_split` was introduced in 
https://github.com/apache/spark/commit/d57daf1f7732a7ac54a91fe112deeda0a254f9ef 
to refactor and support `toDF("...")`; however, 
https://github.com/apache/spark/commit/ebc124d4c44d4c84f7868f390f778c0ff5cd66cb 
replaced the logics here. Seems `_ignore_brackets_split` is not referred 
anymore.
    
    `_BRACKETS` was introduced in 
https://github.com/apache/spark/commit/880eabec37c69ce4e9594d7babfac291b0f93f50;
 however, all other usages were removed out in 
https://github.com/apache/spark/commit/648a8626b82d27d84db3e48bccfd73d020828586.
    
    This is rather a followup for 
https://github.com/apache/spark/commit/ebc124d4c44d4c84f7868f390f778c0ff5cd66cb 
which I missed in that PR.
    
    ## How was this patch tested?
    
    Manually tested. Existing tests should cover this. I also double checked by 
`grep` in the whole repo.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark minor-remove-unused

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20878
    
----
commit 62933ac312b5da19d138fe593c391cbfffe63afb
Author: hyukjinkwon <gurwls223@...>
Date:   2018-03-22T08:17:58Z

    Remove unused codes in schema parsing logics of PySpark

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to