GitHub user arucard21 opened a pull request:
https://github.com/apache/spark/pull/20880
Remove comments that unnecessarily disable Scalastyle check
## What changes were proposed in this pull request?
I re-enabled the Scalastyle checker on a line of code. It was previously
disabled, but it does not violate any of the rules. So there's no reason to
disable the Scalastyle checker here.
## How was this patch tested?
I tested this by running `build/mvn scalastyle:check` after removing the
comments that disable the checker. This check passed with no errors or warnings
for Spark Core
```
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Building Spark Project Core 2.4.0-SNAPSHOT
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- scalastyle-maven-plugin:1.0.0:check (default-cli) @
spark-core_2.11 ---
Saving to outputFile=<path to local
dir>/spark/core/target/scalastyle-output.xml
Processed 485 file(s)
Found 0 errors
Found 0 warnings
Found 0 infos
```
I did not run all tests (with `dev/run-tests`) since this Scalastyle check
seemed sufficient.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/delftswa2018/spark scalastyle_util
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20880
----
commit b6088e2ece672d0b946b786a6d74b11491a84c25
Author: arucard21 <arucard21@...>
Date: 2018-03-22T11:49:06Z
Remove comments that unnecessarily disable Scalastyle check
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
