Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/2922#discussion_r19382277
--- Diff: core/src/main/scala/org/apache/spark/broadcast/Broadcast.scala ---
@@ -87,10 +91,13 @@ abstract class Broadcast[T: ClassTag](val id: Long)
extends Serializable {
/**
* Destroy all data and metadata related to this broadcast variable. Use
this with caution;
* once a broadcast variable has been destroyed, it cannot be used again.
+ * @param blocking Whether to block until destroy has completed
*/
- private[spark] def destroy(blocking: Boolean) {
+ def destroy(blocking: Boolean) {
--- End diff --
Okay if that's the case I'd propose making `destroy()` public and keeping
`destroy(blocking: Boolean)` as private. That way we minimize the surface area
of public APIs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
