Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2685#issuecomment-60533046
Now that Hive 13 is merged in it would be great to get this in ASAP. I
looked over this and it seems pretty good. My only high level comment is maybe
we should keep all the Hive Shim code in a single project instead of having
version specific code in both hive and hive-thrift server. That would simplify
the build and consolidate the places where we have these hacks. It woudl also
allow us to avoid duplicating things like `getCommandProcessor` in both Shims.
Thoughts?
@pwendell can you glance over the (limited) build changes.
@liancheng can you look this over as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
