Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20797#discussion_r177419935
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -266,8 +266,31 @@ case class Invoke(
override def nullable: Boolean = targetObject.nullable || needNullCheck
|| returnNullable
override def children: Seq[Expression] = targetObject +: arguments
- override def eval(input: InternalRow): Any =
- throw new UnsupportedOperationException("Only code-generated
evaluation is supported.")
+ override def eval(input: InternalRow): Any = {
--- End diff --
I basically have the same comments here as for `StaticInvoke`: Why do we
need to resolve the method at runtime? Why are you using
`CodeGenerator.defaultValue(dataType)` to determine if something is a primitive?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
