Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r177940602
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -31,24 +31,24 @@
* for each incoming record, we should call `reset` of BufferHolder
instance before write the record
* and reuse the data buffer.
*
- * Generally we should call `UnsafeRow.setTotalSize` and pass in
`BufferHolder.totalSize` to update
+ * Generally we should call `UnsafeRowWriter.setTotalSize` using
`BufferHolder.totalSize` to update
--- End diff --
Not sure if this description is still here or better to move to
`UnsafeRowWriter`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
