Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2884#issuecomment-60536387
Great, thanks for finding this and adding a test. Regarding the
implementation, I'd like to try to avoid doing too much string munging as its
generally easy to forget to do (hence the issue). Also, in general we try to
avoid looking at string names anywhere other than in analysis. This is the
whole idea behind having expression ids in AttributeReferences (and the idea
behind AttributeMaps).
Since we can't completely get away from string names when working with
Hive, what do you think about this approach:
https://github.com/marmbrus/spark/compare/hiveTableScanCase
I think this more cleanly isolates the need to reason about case
sensitivity into the analysis phase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
