Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r177953620
  
    --- Diff: 
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java 
---
    @@ -515,7 +518,8 @@ public void writeToOutputStreamUnderflow() throws 
IOException {
         final byte[] test = "01234567".getBytes(StandardCharsets.UTF_8);
     
         for (int i = 1; i <= Platform.BYTE_ARRAY_OFFSET; ++i) {
    -      UTF8String.fromAddress(test, Platform.BYTE_ARRAY_OFFSET - i, 
test.length + i)
    +      new UTF8String(
    +        new ByteArrayMemoryBlock(test, Platform.BYTE_ARRAY_OFFSET - i, 
test.length + i))
    --- End diff --
    
    I thought this is what you said 
[here](https://github.com/apache/spark/pull/19222#discussion_r176986304).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to