Github user 10110346 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20862#discussion_r177992858
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
    @@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source: 
ReadableByteChannel, blockSize:
         written
       }
     
    -  override def deallocate(): Unit = source.close()
    +  override def deallocate() {
    +    source.close()
    +    StorageUtils.dispose(buffer)
    --- End diff --
    
    In fact, direct memory is also off-heap memory, 
    if we config this parameter "-XX:+DisableExplicitGC",the memory will not be 
reclaimed


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to