Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20923#discussion_r178195279
  
    --- Diff: hadoop-cloud/pom.xml ---
    @@ -141,13 +93,98 @@
           <artifactId>httpcore</artifactId>
           <scope>${hadoop.deps.scope}</scope>
         </dependency>
    +
       </dependencies>
     
       <profiles>
     
    +    <!-- this inner profile is the default one and includes openstack and 
aws -->
    +    <profile>
    +      <id>hadoop-2.6</id>
    +      <activation>
    +        <activeByDefault>true</activeByDefault>
    --- End diff --
    
    I think that's ok as an initial step. It would be better if you could, in 
profiles, customize independent dependencies (e.g. in the hadoop-3 profile 
exclude some transitive deps), but I'm not sure whether maven would complain 
about something like that.
    
    `jackson-dataformat-cbor` can become interesting if Spark decides to 
upgrade jackson, since the github for that project says it's been removed in 
2.8.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to